fix: enable deviceName
validation on Linux
#34872
Merged
+40
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables printer validity to be verified on Linux. At the moment, if an invalid
deviceName
is passed to Linux, it will just fail silently. This makes it such that the callback is called with a failure if thedeviceName
is invalid, as well as consolidates some of the validation logic so that, among other things,IsDeviceNameValid
is only called once.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where printing with an invalid
deviceName
on Linux caused silent failures.